Merge pull request #706 from joshuarwood/shield_light_fix

Fix for light visibility through shields
This commit is contained in:
fgsfds authored and GitHub committed 2026-03-14 09:15:55 +01:00
commit d58a423e5f
2 files changed
+12 -1

No files matched your search

+11 -1
View File
@@ -4544,7 +4544,17 @@ void chrTestHit(struct prop *prop, struct shotdata *shotdata, bool isshooting, b
if (hitpart) {
if (chrGetShield(chr) > 0.0f) {
var8005efc0 = 10.0f / model->scale;
#ifndef PLATFORM_N64
/**
* var8005efc0 > 0.0f adds a padding to bbox hit detection
* in modelTestBboxNodeForHit() that accounts for a character's
* surrounding shield. We skip this step on PC when checking
* line-of-sight hits to light artifacts because lights should
* be visible through the transparent shield.
*/
if (g_BgHitXluDisabled == false)
#endif
var8005efc0 = 10.0f / model->scale;
}
child = prop->child;
+1
View File
@@ -295,6 +295,7 @@ extern s32 g_JpnMaxCacheItems;
extern s32 var8009d370jf;
#ifndef PLATFORM_N64
extern bool g_ValidGbcRomFound;
extern bool g_BgHitXluDisabled;
#endif
#endif