forked from Ports/goldeneye-pc-port
options UI: anchor all file terminology on the manual's 'game file' (English review)
Full-string audit of the settings UI (front options + F10 overlay): - front top-row label 'Save file' -> 'Game file' (the instruction manual's term) - per-file row tag '(profile)' -> '(game file)', both UIs - F10 unavailable value 'Select file' -> 'Select game file' - kept: 'File N' values, the '(File N)' section annotation and the '(no file)' unavailable state (short forms; the annotation's host word is the section title, which says the file number) - 'Bond file' now appears only in identifiers/config keys (Bond.* rows, watchSettings* names, ini keys), never user-visible Docs: D357 plan section 4 is now the terminology record (final string table); D358 finding notes the (profile) -> (game file) supersession. Build + headless smoke clean.
This commit is contained in:
1 parent
8775ca6435
commit
44d2b4353a
4 files changed
+37
-21
No files matched your search
@@ -9,7 +9,9 @@ the `Bond.*` rows only). Triggered by maintainer report: the current values
|
||||
are "a bit confusing".
|
||||
|
||||
Companion change landed with this doc's review: the dim per-file row tag is
|
||||
now **"(profile)"** (was "(save)"; user request, both UIs).
|
||||
now **"(game file)"** (was "(save)"); the front top row reads **"Game
|
||||
file"** and the F10 unavailable value reads **"Select game file"** — the
|
||||
instruction manual's term (§4).
|
||||
|
||||
## 1. Problem
|
||||
|
||||
@@ -111,13 +113,23 @@ ranges (2026-09-27). "Display" = what the value column shows today.
|
||||
| Frame rate cap | 60 · 0–1000 · 1 · `Uncapped/N FPS` | Turok: "up to 120 FPS" / uncapped | **Preset grid**: 0/30/60/120/144 (step = next preset, wraps to Uncapped); value text already `N FPS`/`Uncapped`. Decision: preset grid vs free 1-step (recommend presets; 117 FPS has no purpose). |
|
||||
| Show FPS | Off/On | both | Keep. |
|
||||
|
||||
## 4. Terminology
|
||||
## 4. Terminology (instruction manual = "game file")
|
||||
|
||||
- Per-file row tag: **"(save)" → "(profile)"** (landed with this doc's
|
||||
review; `frontoptions.c` + `optionsoverlay.c`, both draw paths + comments).
|
||||
- Open question for the maintainer: the front screen's top row still reads
|
||||
**"Save file: File N"** — rename to "Profile: File N" for consistency?
|
||||
(Not done; the save *file* is literally what's being chosen.)
|
||||
The instruction manual calls the per-player save a **"game file"**; the
|
||||
settings UI anchors on that term (2026-09-27, maintainer request). Final
|
||||
string set:
|
||||
|
||||
| String | Where | State |
|
||||
|---|---|---|
|
||||
| **"Game file"** | front options top-row label (was "Save file") | changed |
|
||||
| **"(game file)"** | per-file row tag, both UIs (was "(save)", briefly "(profile)") | changed |
|
||||
| **"Select game file"** | F10 unavailable value (was "Select file") | changed |
|
||||
| `File N` | row values + the `(File N)` section annotation | kept (value-column short form, PD "Player N" pattern) |
|
||||
| `(no file)` | unavailable state, dim annotation | kept |
|
||||
|
||||
"Bond file" remains in code identifiers/config keys (`Bond.*` rows,
|
||||
`watchSettingsChooseFile`, ini keys) only -- never user-visible; the manual
|
||||
and UI say "game file".
|
||||
|
||||
## 5. Gates
|
||||
|
||||
|
||||
@@ -13965,4 +13965,7 @@ and are untouched. Verified by build + headless boot smoke; visual check
|
||||
of the screen owed (D357 plan gate 4).
|
||||
|
||||
**Companion change (same commit):** the per-file row tag now reads
|
||||
"(profile)" (was "(save)", maintainer request), both UIs.
|
||||
"(profile)" (was "(save)", maintainer request), both UIs. (Later the same
|
||||
day the tag and the rest of the file terminology were anchored on the
|
||||
instruction manual's "game file" term: "(game file)" tag, "Game file" top
|
||||
row, "Select game file" -- D357 plan §4.)
|
||||
Reference in new issue
Block a user