From cb5295fe8584e469feaff0cc29379afba4dbd8ff Mon Sep 17 00:00:00 2001 From: James Dansereau <106631954+jkdansereau@users.noreply.github.com> Date: Mon, 31 Aug 2026 11:10:58 -0400 Subject: [PATCH] GE_SAVELOG: trim criterion dump to essentials (D157 confirmed fixed) Drop the verbose raw-words / DESTROY obj-ptr-healthy lines now that D157 is root-caused + confirmed. Keep the compact per-criterion line (type/ObjRefID/MinDif/stride/status) and the per-objective difficulty-gate line -- both are the reusable signal for any future save/objective issue, gated by g_savelogObjOnce + GE_SAVELOG so inert in normal play. --- src/game/objective_status.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/src/game/objective_status.c b/src/game/objective_status.c index 53c5814f..541fca6c 100644 --- a/src/game/objective_status.c +++ b/src/game/objective_status.c @@ -195,13 +195,6 @@ OBJECTIVESTATUS get_status_of_objective(s32 objectiveNum) //#MATCH { currentstatus = OBJECTIVESTATUS_INCOMPLETE; } -#ifdef PORT - if (g_savelogObjOnce && getenv("GE_SAVELOG")) - osSyncPrintf("SAVELOG: DESTROY tag=%d obj=%p prop=%p healthy=%d\n", - (int)objective->ObjRefID, (void *)obj, - obj ? (void *)obj->prop : NULL, - obj ? (int)objIsHealthy(obj) : -1); -#endif break; } case PROPDEF_OBJECTIVE_COMPLETE_CONDITION: @@ -297,16 +290,17 @@ OBJECTIVESTATUS get_status_of_objective(s32 objectiveNum) //#MATCH } } #ifdef PORT - if (g_savelogObjOnce && getenv("GE_SAVELOG")) { - u32 *rw = (u32 *)objective; + /* GE_SAVELOG: one line per objective criterion the walk visits + (type / ref id / stride / status) -- gated by g_savelogObjOnce + so only the bossReturnTitleStage completion check logs, not + the per-frame poll. */ + if (g_savelogObjOnce && getenv("GE_SAVELOG")) osSyncPrintf("SAVELOG: crit obj=%d type=%d ObjRefID=%d " - "TextID=0x%x MinDif=%d stride=%d words=[%08x %08x %08x %08x] " - "curstat=%d\n", + "MinDif=%d stride=%d curstat=%d\n", objectiveNum, (int)objective->type, (int)objective->ObjRefID, - (unsigned)objective->TextID, (int)objective->MinDificulty, + (int)objective->MinDificulty, (int)sizepropdef((PropDefHeaderRecord *)objective), - rw[0], rw[1], rw[2], rw[3], (int)currentstatus); - } + (int)currentstatus); #endif if (status == OBJECTIVESTATUS_COMPLETE) {