popux/perfect_dark
1
0 Fork 0
forked from Ports/perfect_dark
Code Pull Requests Activity

Fix issue for some cheats across build optimizations

Browse Source
This commit is contained in:
TartanSpartan committed 2026-02-12 00:55:28 +00:00
1 parent 246d737663
commit 426f9c6890
1 file changed
+5 -4
Download Patch File Download Diff File Expand all files Collapse all files
src/game/cheats.c
+5 -4
View File
@@ -309,7 +309,7 @@ MenuItemHandlerResult cheatCheckboxMenuHandler(s32 operation, struct menuitem *i
return false;
}
if (g_CheatsEnabledBank1 & (1 << item->param)) {
if (g_CheatsEnabledBank1 & (1 << (item->param - 32))) {
return true;
}
@@ -334,11 +334,12 @@ MenuItemHandlerResult cheatCheckboxMenuHandler(s32 operation, struct menuitem *i
}
} else {
// Bank 1
if (g_CheatsEnabledBank1 & (1 << item->param)) {
if (g_CheatsEnabledBank1 & (1 << (item->param - 32))) {
// We need to subtract 32 on lines like these to avoid undefined behavior, namely ensuring that all cheats are toggled correctly and regardless of build optimiaztion
if (1);
g_CheatsEnabledBank1 = g_CheatsEnabledBank1 & ~(1 << item->param);
g_CheatsEnabledBank1 = g_CheatsEnabledBank1 & ~(1 << (item->param - 32));
} else {
g_CheatsEnabledBank1 = g_CheatsEnabledBank1 | 1 << item->param;
g_CheatsEnabledBank1 = g_CheatsEnabledBank1 | (1 << (item->param - 32));
}
}
}